-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] A way of dealing with furigana in subtitles. #30
Comments
Seems to be exactly related to this Yomichan issue and I will have to offer a similar solution. |
I am on hiatus but this is pretty easy to offer a band-aid solution to this with a regular expression filter so I've gone ahead and implemented it in 0.25.5. You will need to apply the following filter if you want to hide anything within parentheses as per the linked Yomichan solution: I believe this is a broad solution that can be adaptable to different ways Furigana can be represented and you will have to be proficient in regular expressions should you find a format that doesn't quite fit the Netflix subtitles pattern but the filter above should function well enough for your purposes. I should mention I will be on hiatus for a short while, so if there are any newer issues I won't be able to address them as soon as I have, I should be reading but I figure this one change is pretty fast enough to make. If there are any additional issues, feel free to re-open. |
I've reuploaded that release so that the filter should also work on subtitles upon export. |
No problem. Go and immerse yourself. I've doing a great job lately. We really appreciate the time you've spent developing this tool. |
I've found a problem with subs that have furigana, mainly those you find on Netflix subs.
The word can't be parsed at all because there's furigana on almost every kanji. My request is:
You can find the subtitle in the screenshots here. But it's pretty common to have furigana in subs — I personally find them annoying.
I'm not aware of other patterns to indicate furigana, so far I've only encountered the one present in the screenshots. There might be more patterns.
The text was updated successfully, but these errors were encountered: