Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background Panel #6

Open
Snichy opened this issue Nov 10, 2022 · 6 comments
Open

Background Panel #6

Snichy opened this issue Nov 10, 2022 · 6 comments
Labels
maybe? I might add it, but no promises

Comments

@Snichy
Copy link

Snichy commented Nov 10, 2022

Would like the option of having a plain consistent background panel, without the gradient. Or at the very least a Gradient that fades from left to right rather than from in the middle outward.

@ls-
Copy link
Owner

ls- commented Nov 10, 2022

I'll think about it, no promises tho...

@ls- ls- added the maybe? I might add it, but no promises label Nov 10, 2022
@Kebaronrin
Copy link

Would also like to see this as a feature. I always wanted it in the old Glass as well. For anybody else who might stumble across this and would like a jank workaround in the (hopeful) meantime, you just have to make a quick and easy edit to one file.

  • Open the ls_Glass\core\components\messageline.lua file.
  • On line 24, change self:SetGradientBackgroundSize(E:Round(width * 0.1), E:Round(width * 0.4)) to self:SetGradientBackgroundSize(width, width)
  • On line 37, change E:CreateGradientBackground(frame, E:Round(width * 0.1), E:Round(width * 0.5), 0, 0, 0, C.db.profile.chat.alpha) to E:CreateGradientBackground(frame, width, width, 0, 0, 0, C.db.profile.chat.alpha)

image

@Snichy
Copy link
Author

Snichy commented Nov 11, 2022

@Kebaronrin That's perfect - this might actually convince me to move away from Prat as Glass looks so much nicer with a consistent background. Sounds like there'll be a lot of updates to LSs version to squash the bugs which will probably overwrite any custom LUA changes so maybe Ill hold off for a while!

@ls-
Copy link
Owner

ls- commented Nov 11, 2022

Dw, now that the addon is fairly stable aside from one annoying scrolling bug, I'm taking a break. I spent last ~6 weeks prepping for the prepatch and then working Glass despite having covid that lasted for like 3 weeks. That's just too much, it's not even the 2nd phase of the prepatch and I'm practically burnt out. I need a break. In the meantime feel free to mod it.

@Knaledge
Copy link

Knaledge commented Dec 5, 2022

Maybe this entire project could be ported to Prat as a PR. There is a lot (a lot) of overlapping functionality and nearly everything in each open issue is already present in Prat. The one thing not in Prat is a reskinning of the default chatbox elements (tabs, scrollbar/buttons, etc.).

@ls-
Copy link
Owner

ls- commented Dec 18, 2022

Our projects have different goals. I have no interest in even attempting to merge it with prat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maybe? I might add it, but no promises
Projects
None yet
Development

No branches or pull requests

4 participants