-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lectures
: Improve the file upload for attachments
#5427
Lectures
: Improve the file upload for attachments
#5427
Conversation
File Upload:
Replace file upload attachments with a single requestFile Upload
: Replace file upload attachments with a single request
a196501
to
d8ddc9c
Compare
bb7d207
to
bece305
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial pass over the server code, no in-depth code-review yet.
src/main/java/de/tum/in/www1/artemis/web/rest/FileResource.java
Outdated
Show resolved
Hide resolved
implemented the change requests
61a618c
to
b20c8ca
Compare
49f8647
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code re-approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactoring looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved 👍
File Upload
: Replace file upload attachments with a single requestLecture
: Replace file upload attachments with a single request
Lecture
: Replace file upload attachments with a single requestLectures
: Replace file upload attachments with a single request
Lectures
: Replace file upload attachments with a single requestLectures
: Improve the file upload for attachments
Checklist
General
Server
@PreAuthorize
and checked the course groups for all new REST Calls (security).Client
Motivation and Context
As part of my bachelor's thesis, I'm replacing the file upload occurrences with a more secure way.
The first occurrences are the attachments that I'm addressing in this PR.
Description
Steps for Testing
Prerequisites:
Note: While creating and editing, keep track with your student account if everything works out from the student's point of view (especially the download of the files)
Review Progress
Code Review
Manual Tests
Test Coverage