-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Reimplement course icon file upload
#5733
Conversation
Course
: Rreimplement course icon file uploadCourse
: Reimplement course icon file upload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS1 in the testing session.
When editing the course without uploading a new icon, I can click the save button, but the changes are not persisted (no request sent to the server).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#5691 adds the possibility to delete the course icon. Maybe you could talk to the other developer and find a unified solution for your both PRs
src/main/java/de/tum/in/www1/artemis/web/rest/CourseResource.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/web/rest/CourseResource.java
Outdated
Show resolved
Hide resolved
src/test/javascript/spec/component/course/course-update.component.spec.ts
Show resolved
Hide resolved
512347d
to
4c0db3f
Compare
627442a
to
36963d2
Compare
36963d2
to
cf1ed38
Compare
cf1ed38
to
b6abe6e
Compare
b6abe6e
to
9d721f7
Compare
071c53b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm. Gj!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the code changes again. Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove
Course
: Reimplement course icon file uploadDevelopment
: Reimplement course icon file upload
Checklist
General
Server
@PreAuthorize
and checked the course groups for all new REST Calls (security).Client
Motivation and Context
Follows #5427 to reimplement all file uploads in our system in a uniform and secure way.
Description
PUT /api/course
toPUT /api/course/:id
to reflect our standard. I, therefore, also removed the implementation to create a course with PUT. This is not used in our system and only complicates the implementation.Steps for Testing
Prerequisites:
Review Progress
Code Review
Manual Tests
Test Coverage
Screenshots
Before
After