Development: Reimplement attachment file upload

[julian-christl]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
• I followed the coding and design guidelines.
• I added multiple integration tests (Spring) related to the features (with a high test coverage).
• I documented the Java code using JavaDoc style.

Client

• Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
• I followed the coding and design guidelines.
• I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
• I documented the TypeScript code using JSDoc style.

Motivation and Context

Follow-up of #5733 and #5427 to replace the file upload before entity persistence with a multipart file and entity upload.

Description

I simply extended the endpoints to save an attachment to also allow a file upload (forced for creation), save one REST call and make the system safer. No UI changes were necessary..

Steps for Testing

Prerequisites:

• 1 Instructor
• 1 Student

1. Create a lecture in a course
2. Navigate to the "Attachments" of this lecture (not the attachment units!)

• Create an attachment
• Update the attachment with a new file
• Update the attachment without a new file
• Make sure that the student can see the file and the changes correctly

Review Progress

Performance Review

• I confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
• I confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Test Coverage

I added assertions where needed. However, for most of the changes, the existing assertions were already enough.

Class/File	Line Coverage	Confirmation (assert/expect)
AttachmentResource.java	98.1%	✅
attachment.service.ts	95.9%	✅
lecture-attachments.component.ts	99%	✅

[github-actions]

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

[codecov-commenter]

Codecov Report

Merging #6569 (19acb9c) into develop (5ac110a) will decrease coverage by 0.01%.
The diff coverage is 82.65%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #6569      +/-   ##
=============================================
- Coverage      80.39%   80.38%   -0.01%     
+ Complexity     13588    13587       -1     
=============================================
  Files           2398     2399       +1     
  Lines          91684    91692       +8     
  Branches       12870    12871       +1     
=============================================
+ Hits           73706    73710       +4     
- Misses          9886     9888       +2     
- Partials        8092     8094       +2     

Impacted Files	Coverage Δ
.../java/de/tum/in/www1/artemis/config/Constants.java	100.00% <ø> (ø)
...m/in/www1/artemis/web/rest/CompetencyResource.java	95.02% <0.00%> (ø)
...ebapp/app/course/manage/course-update.component.ts	74.43% <50.00%> (-0.79%)	⬇️
...ain/java/de/tum/in/www1/artemis/domain/Course.java	85.77% <66.66%> (-0.82%)	⬇️
src/main/webapp/app/lecture/attachment.service.ts	83.67% <77.77%> (-0.05%)	⬇️
...ww1/artemis/service/AuthorizationCheckService.java	75.57% <82.35%> (+0.37%)	⬆️
...ebapp/app/lecture/lecture-attachments.component.ts	88.46% <86.95%> (+2.62%)	⬆️
...e/tum/in/www1/artemis/web/rest/CourseResource.java	90.78% <92.30%> (ø)
.../www1/artemis/repository/AttachmentRepository.java	100.00% <100.00%> (ø)
...m/in/www1/artemis/repository/CourseRepository.java	92.68% <100.00%> (ø)
... and 5 more

... and 4 files with indirect coverage changes

Flag	Coverage Δ
client	76.12% <78.57%> (-0.01%)	⬇️
server	85.05% <85.71%> (-0.01%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0532ade...19acb9c. Read the comment docs.

[JohannesStoehr]

Reapprove code

[DominikRemo]

Reapproved

[tunargs]

I tested it on ts1, works perfectly. The code looks good as well.

[MarkusPaulsen]

Code looks good and tested on ts1.

[dearjasmina]

Tested on ts1, works as expected
Code looks great as well :)

fixed