Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Fix multipart course creation in k6 tests #5872

Merged
merged 6 commits into from
Nov 28, 2022

Conversation

sleiss
Copy link
Contributor

@sleiss sleiss commented Nov 23, 2022

Checklist

General

Motivation and Context

In #5574 and #5733, the endpoint to create courses was

  1. Moved to a different path
  2. Changed to a multipart form

These changes were not reflected within the k6 tests.
This PR adjusts the paths and changes the course creation to multi-part forms.

Steps for Testing

See that the tests pass again:

Review Progress

Code Review

  • Review 1
  • Review 2

Manual Tests

  • Test 1
  • Test 2

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Base: 79.91% // Head: 79.91% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (724a08c) compared to base (1fd6131).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5872      +/-   ##
=============================================
- Coverage      79.91%   79.91%   -0.01%     
  Complexity     12352    12352              
=============================================
  Files           2125     2125              
  Lines          84226    84226              
  Branches       12633    12633              
=============================================
- Hits           67309    67307       -2     
- Misses          9390     9392       +2     
  Partials        7527     7527              
Flag Coverage Δ
client 75.63% <ø> (ø)
server 84.65% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ce/scheduled/ParticipantScoreSchedulerService.java 82.11% <0.00%> (-1.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sleiss sleiss changed the title Support multipart form creation in k6. Development: Support multipart course creation in k6 tests. Nov 24, 2022
@sleiss sleiss changed the title Development: Support multipart course creation in k6 tests. Development: Fix multipart course creation in k6 tests. Nov 24, 2022
@sleiss sleiss marked this pull request as ready for review November 24, 2022 07:58
@sleiss sleiss requested a review from a team as a code owner November 24, 2022 07:58
@artemis-bot artemis-bot moved this from In progress to Ready for review in Artemis Development Nov 24, 2022
@sleiss sleiss added this to the 5.12.6 milestone Nov 24, 2022
julian-christl
julian-christl previously approved these changes Nov 24, 2022
Copy link
Member

@julian-christl julian-christl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@krusche krusche changed the title Development: Fix multipart course creation in k6 tests. Development: Fix multipart course creation in k6 tests Nov 25, 2022
Artemis Development automation moved this from Ready for review to Review in progress Nov 25, 2022
b-fein
b-fein previously approved these changes Nov 25, 2022
Copy link
Contributor

@b-fein b-fein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing the suggestion. Looks good!

@krusche krusche merged commit c8ae6cb into develop Nov 28, 2022
@krusche krusche deleted the bugfix/k6-course-multipart branch November 28, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Artemis Development
  
Review in progress
Development

Successfully merging this pull request may close these issues.

None yet

5 participants