Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to navigate back to Artemis from external webcontent #33

Closed
ungaralex opened this issue Nov 17, 2020 · 0 comments · Fixed by #45
Closed

Allow users to navigate back to Artemis from external webcontent #33

ungaralex opened this issue Nov 17, 2020 · 0 comments · Fixed by #45
Assignees
Labels
feature New feature or request good first issue Good for newcomers priority:low

Comments

@ungaralex
Copy link
Contributor

This was the result of a discussion we had way back, where we decided to not let users break out of the "Artemis space" since we can't really guarantee what will happen as only the usage with the Artemis website is tested.
Let's also say a teaching assistant links a code example and the student clicks on it. He is now outside of our domain and has no obvious way of going back, apart from re-opening the IDE/reloading in the settings/left-click context menu.

Now, for this specific case, we absolutely should allow users to use external login mechanisms. What I wanted to have and would be my favorite solution, is to remove the pop-up completely and then have a button above the browser (so an IDE-native button on top off the tool window next to the default ones), which always brings you back to the Artemis homepage if you have any problems whatsoever. An alternative would be to have a prominent button overlayed, having the same functionality, as soon as we detect a user leaving the domain.
No matter what, removing the current blocking of external domains should be the first step @nutatuna .

Originally posted by @ungaralex in #30 (comment)

@ungaralex ungaralex added feature New feature or request good first issue Good for newcomers priority:low labels Nov 17, 2020
@MDK5 MDK5 mentioned this issue Apr 18, 2021
@MDK5 MDK5 linked a pull request Apr 19, 2021 that will close this issue
@MDK5 MDK5 self-assigned this May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers priority:low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants