Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statistics section: UI enhancements #164

Merged
merged 5 commits into from
Jul 20, 2023

Conversation

terlan98
Copy link
Contributor

@terlan98 terlan98 commented Jul 14, 2023

  • Removed rectangular background from statistics circles
  • Added progress description (like 7/10) under the percentage text
  • Fixed decimal formatting issues
  • Clamped percentage values to 0...100 range to prevent weird results, like 1000%
Before After
before_themis after_themis
before_spacex after_spacex

@terlan98 terlan98 marked this pull request as ready for review July 14, 2023 18:49
@maximiliansoelch
Copy link
Member

Tested it locally, looks good 👍
Short question regarding the behavior when dividing by 0:

  1. Here, the progress shows NaN
    Simulator Screenshot - iPad Pro (12 9-inch) (6th generation) - 2023-07-17 at 12 21 21

  2. Here, the progress is 100%
    Simulator Screenshot - iPad Pro (12 9-inch) (6th generation) - 2023-07-17 at 12 23 12

Is this the intended behavior?

@terlan98
Copy link
Contributor Author

Tested it locally, looks good 👍 Short question regarding the behavior when dividing by 0:

  1. Here, the progress shows NaN
    Simulator Screenshot - iPad Pro (12 9-inch) (6th generation) - 2023-07-17 at 12 21 21
  2. Here, the progress is 100%
    Simulator Screenshot - iPad Pro (12 9-inch) (6th generation) - 2023-07-17 at 12 23 12

Is this the intended behavior?

Thanks for pointing out. I added a new commit that deals with such cases and ensures that we always show 0% instead of N/A 🙂

Copy link
Member

@maximiliansoelch maximiliansoelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works as expected.
Code LGTM 👍

@maximiliansoelch maximiliansoelch merged commit 6c381b1 into develop Jul 20, 2023
@maximiliansoelch maximiliansoelch deleted the enhancement/statistics-progress-bars branch July 20, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants