Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lsd compile with x86_64-pc-windows-gnu as target #51

Closed
Peltoche opened this issue Dec 10, 2018 · 3 comments
Closed

Make lsd compile with x86_64-pc-windows-gnu as target #51

Peltoche opened this issue Dec 10, 2018 · 3 comments
Labels
help wanted Extra attention is needed kind/enhancement Enhancement on current feature

Comments

@Peltoche
Copy link
Collaborator

No description provided.

@Peltoche Peltoche added kind/enhancement Enhancement on current feature help wanted Extra attention is needed labels Dec 10, 2018
@danieldulaney
Copy link
Contributor

Hi! I'd love to take on Windows support for lsd.

It looks like a basic approach should be fairly doable. By shimming a couple of functions in the meta modules, we can get something that works. However, translating Windows permissions into Unix-style permissions is always tricky.

I stubbed out the required functions here: master...danieldulaney:windows-support. Let me know if you think this is a good approach, and I'll work on implementation.

@Peltoche
Copy link
Collaborator Author

Hello @danieldulaney ,

You approach looks all good to me. I hope to see you PR soon :)

@danieldulaney
Copy link
Contributor

#116 proposed to close this.

@Peltoche Peltoche closed this as completed Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/enhancement Enhancement on current feature
Projects
None yet
Development

No branches or pull requests

2 participants