Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby3.3 causes failure for YARD::Parser::SourceParser#parse understands UTF-8 BOM #1509

Closed
mtasaka opened this issue Sep 24, 2023 · 2 comments · Fixed by #1510
Closed

ruby3.3 causes failure for YARD::Parser::SourceParser#parse understands UTF-8 BOM #1509

mtasaka opened this issue Sep 24, 2023 · 2 comments · Fixed by #1510

Comments

@mtasaka
Copy link
Contributor

mtasaka commented Sep 24, 2023

With ruby 3.3 (I tested ruby/ruby@2ceb536 ) yard 0.9.34 ( 698b22c ) spec testsuite fails like:

$ rspec -r spec_helper spec

Failures:

  1) YARD::Parser::SourceParser#parse understands UTF-8 BOM
     Failure/Error: expect(Registry.all(:class).first.path).to eq "FooBar"

       expected: "FooBar"
            got: "FooBa"

       (compared using ==)
     # ./spec/parser/source_parser_spec.rb:589:in `block (4 levels) in <top (required)>'
     # ./spec/spec_helper.rb:129:in `block (2 levels) in <top (required)>'

ruby 3.2.2 does not see this error. For now I don't know what ruby side change caused this.

@MSP-Greg
Copy link
Contributor

@mtasaka

I verified the error on both Ubuntu 22.04 & Windows, using master of YARD and Ruby master versions as of today.

I believe #1510 fixes it. My systems are US-EN, so if you can check it locally, it would be appreciated...

@mtasaka
Copy link
Contributor Author

mtasaka commented Sep 24, 2023

Yes, #1510 fixes this. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants