Coveralls support #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| :else nil)) lines)})) | ||
| (filter (fn [[file _]] file) | ||
| (group-by :file forms)))] | ||
| (with-out-writer (File. (File. out-dir) "coveralls.json") |
There was a problem hiding this comment.
Simply (File. out-dir "coveralls.json") should do.
There was a problem hiding this comment.
Fixed, thanks. In fact I adapted this code from the line 264.
There was a problem hiding this comment.
Hah, I should fix that :P
|
Other than those two very minor issues this looks good to me. Thanks! |
|
Would you mind pushing the snapshot on Clojars so I can add it as a dependency in my repos? |
|
Will do this evening. |
|
Done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Coveralls (#38), writing the JSON in
${outdir}/coveralls.json, users are then free to send it to Coveralls using their API.