Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method "setImage" has a problem #72

Closed
CyrusHeo opened this issue Feb 6, 2023 · 3 comments
Closed

Method "setImage" has a problem #72

CyrusHeo opened this issue Feb 6, 2023 · 3 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed wontfix This will not be worked on

Comments

@CyrusHeo
Copy link

CyrusHeo commented Feb 6, 2023

Param $page doesn't work .

**
check the file here : lsnepomuceno/laravel-a1-pdf-sign/src/SignaturePdf.php Line: 266

When $this->hasSealImgOnEveryPages === false , The correct codes should be like this :

if ($this->hasSealImgOnEveryPages) {
                $this->implementSignatureImage($i);
            }else{
                extract($this->image);
                if($page == $i){
                    $this->implementSignatureImage($page);
                }
            }
@CyrusHeo CyrusHeo added bug Something isn't working help wanted Extra attention is needed labels Feb 6, 2023
@lsnepomuceno
Copy link
Owner

What version of the package, Laravel, etc?

let me know more details.

@lsnepomuceno
Copy link
Owner

As the issue template was not used, informing important versions to identify the problem, I will consider the problem as a "false positive".

If the issue is sent again, please use the consistent template containing the information necessary to identify the problem.

@lsnepomuceno lsnepomuceno added the wontfix This will not be worked on label Feb 7, 2023
Repository owner locked as resolved and limited conversation to collaborators Feb 7, 2023
@lsnepomuceno
Copy link
Owner

Hello @CyrusHeo ,

The fix was implemented in PR #85 and is now available from version v1.0.7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants