DM-13353: Add support for Formatter writeRecipes #305
Conversation
timj
force-pushed
the
tickets/DM-13353
branch
2 times, most recently
from
aacd636
to
b25bab2
Compare
There was a problem hiding this comment.
Looks good. A couple of line comments, and also:
-
I had been trying to keep all Registry configuration keys snake_case (at least dimensions config; I haven't paid quite as much attention to other registry config). If Datastore configuration is consistently camelCase, maybe we should just accept that boundary - if not, we'll need to standardize on one or the other soon.
-
You've got a typo in one of your commit messages ("Consitently").
|
I'm happy to change the key to write_recipes. As for obs_base -- we haven't really solved the problem of how obs_base can introduce config items that can merge with daf_butler repo config items or override certain entries. Formatters are the sort of thing where it's clearly going to get annoying if every time some new stack high level object needs to be serialized we require that daf_butler gets a new StorageClass and new default Formatter entry. |
This was added in for mypy but it changes the default behavior. Remove it and ignore the mypy warning on makeUpdatedLocation. Also adds a note explaining the issue with extension being optional for a formatter.
This simplifies some assumptions that datastores are making about formatter.extension.
formatter.extension is mostly going to work fine but it is safer to go through the Location object.
Config might be confusing since we only used Config for a specific purpose
These come from obs_base originally in the gen2 implementation.
Almost no-one using the top level Butler interface will be ingesting files in-place. Change the default to auto so that there is more chance of a correct default being used.
This makes it more consistent with other Butler YAML.
No description provided.