DM-13353: Add FITS compression support to gen3 formatter #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires lsst/daf_butler#305 |
timj
commented
Jun 5, 2020
| return recipe | ||
|
|
||
| # @staticmethod | ||
| def validateWriteRecipes(self, recipes): |
There was a problem hiding this comment.
@jonathansick points out that pydantic would be perfect here instead of hand crafted validation.
PaulPrice
approved these changes
Jun 8, 2020
| * quantizePad: number of stdev to allow on the low side (for | ||
| STDEV_POSITIVE/NEGATIVE) | ||
| * bscale: manually specified BSCALE (for MANUAL scaling) | ||
| * bzero: manually specified BSCALE (for MANUAL scaling) |
There was a problem hiding this comment.
The four above are float.
Should the types be in backticks?
There was a problem hiding this comment.
Oh. Hadn't thought about it since I copied it directly and never read it. Will see what the docs look like.
Also includes tests of lossless, no compression, and lossy. Uses the gen2 cameraMapper code and writeRecipes.yaml content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.