DM-42636: Support universe that uses day_obs and group in exposure record #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-42636
branch
2 times, most recently
from
5995c1d
to
2dcdcfc
Compare
timj
force-pushed
the
tickets/DM-42636
branch
3 times, most recently
from
486daca
to
5406239
Compare
2 tasks
timj
commented
Feb 19, 2024
TallJimbo
approved these changes
Feb 20, 2024
timj
force-pushed
the
tickets/DM-42636
branch
4 times, most recently
from
20a1e19
to
f4da303
Compare
TallJimbo
approved these changes
Feb 28, 2024
This supports visit definition from group dimension.
timj
force-pushed
the
tickets/DM-42636
branch
3 times, most recently
from
0e9c09e
to
576a634
Compare
2 tasks
timj
force-pushed
the
tickets/DM-42636
branch
2 times, most recently
from
3bbdb53
to
c875a72
Compare
This requires that we call a method on the Instrument class to get the group_id from the name.
Uses ObservationInfo.observing_day_offset
This allows subclasses to call the parent class even if exposure is not known.
This allows the codepath to be tested with and without the offset. Only change a single dataset and move it to a different day to avoid definition inconsistencies.
This can be used to calculate the observing day offset when importing old registry YAML files into a butler repository.
timj
force-pushed
the
tickets/DM-42636
branch
from
c875a72
to
0c44de8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lsst/astro_metadata_translator#71, lsst/pipe_base#402 and lsst/daf_butler#953
Checklist
doc/changes