tickets/DM-21531 #10
Merged
tickets/DM-21531 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove assert that isn't useful * increase proxmin minimal version to 0.5.4 * Add __eq__ to BoundingBox * Remove unused import * Add test for uncentered_operator * Fix tests for source updates * Remove tests for obsolete transformation module * Remove obsolete notes * Update bbox module and create tests While writing tests I found that the `BoundingBox` API was clunky and supported features that were inconsistent. The new implementation is cleaner and uses a shortened `Box` class name. The `resize` method was also removed, because it didn't add anything to the functionality of trim. * Add tests for psf functions * Add method to generate PSF image Generating a PSF image for given function in a given shape is common enough that a convenience method has been added to generate the x, y pixel grid for the shape and create a PSF image using the function parameters. * Create tests for observation.py While creating the tests a few inconsistencies/sloppy coding were fixed: - `Scene.psfs` is now always 3D, even the `target_psf` for the model scene. This makes the API more uniform for `Scene` and its inherited classes. - PSF matching and convolutions now use real FFTs. This has the advantage that it runs faster, fixes a potential bug in the PSF matching code, and is more similar to the `scipy.signal.convolve` method. * Create unit tests for component.py In addition to creating the units tests for the classes in component.py, the commit also fixes the `Prior` API to use the form `sed_grad` and `morph_grad` (instead of `grad_sed`, ...) to match the attributes of `Component`. * ndim fft for observation.get_match * ndim fft for single observations * Progress on ndim fft and multires operator * test fftstack * test fftstack * debugging * plot debugg * plot debugg * plot debugg * Working version of N-dim fft * Working version of N-dim fft * multi-resolution Ndimfft implemented * Ndim fft on LowRes * getting closer * check that ker is what it's supposed to be * test coordinates * test coordinates * commit before pull * commit before pull * First attempt at solving merge conflicts * after merge convolution fix * debugging LowRes * still fixing bug * ready version before tests * ready version before tests * giving up * Upcoming PR * changes based on Peter's review * tests proof * passing tests * cprofile * timing * timing iterations * timing iterations * almost PR ready * almost PR ready * PRable version. Ndim fft where possible * timing comparison * I think I fixed the -1 thingy in ffts * fft shapes fixed * useless commit to put symmetry back on in * resurrected change log
…rac is less of a problem
Fastfft symmetry
….symmetric gets explicit pixel_center
…ation and no sinc evaluation
Fast resampling
Add Fourier class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.