Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-39965: Adopt lsst-sqre's build-and-push-to-ghcr@v1 and build-and-publish-to-pypi@v2 #213

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

jonathansick
Copy link
Member

For the fastapi_safir_app template:

For the square_pypi_package template:

  • Use lsst-sqre/build-and-publish-to-pypi@v2. This uses PyPI's trusted publishers mechanism for authorizing the upload.
  • Trigger releases on the release.published event, rather than on tagging. This adds extra intentionality around releases.

- This now uses the PyPI trusted publishers program
- PyPI releases are now done on a GitHub Release "published" event
  rather than simply on a tag push; this provides additional
  intentionality for releases.
- Since the actual PyPI release uses a dedicated environment, we now
  have a separate job to pre-flight the packaging with twine check.
@jonathansick jonathansick requested a review from rra July 11, 2023 15:13
Copy link
Member

@rra rra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, and so much cleaner!

@jonathansick jonathansick merged commit 9c744fd into main Jul 11, 2023
4 checks passed
@jonathansick jonathansick deleted the tickets/DM-39965 branch July 11, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants