DM-10625: Make a copy of spec when resolving it #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a specification has a base that can't be resolved, then an exception is thrown in the resolve() method, indicating that it should be added to a retry pile. But we're also modifying that specification in the resolve_document() method. So when we actually do retry the resolution, the specification may not be in a good state. Doing a deep copy of the original specification in resolve_document() solves all these things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a specification has a base that can't be resolved, then an exception is thrown in the
resolve_document()method, indicating that it should be added to a retry pile. But we're also modifying that specification in theresolve_document()method. So when we do retry the resolution, the specification may not be in a good state.Doing a deep copy of the original specification in
resolve_document()solves all these things.