Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-10625: Make a copy of spec when resolving it #12

Merged
merged 1 commit into from
May 26, 2017
Merged

DM-10625: Make a copy of spec when resolving it #12

merged 1 commit into from
May 26, 2017

Commits on May 26, 2017

  1. Make a copy of spec when resolving it 

    If a specification has a base that can't be resolved, then an exception
is thrown in the resolve() method, indicating that it should be added to
a retry pile. But we're also modifying that specification in the
resolve_document() method. So when we actually do retry the resolution,
the specification may not be in a good state.

Doing a deep copy of the original specification in resolve_document()
solves all these things.
    @jonathansick
    jonathansick committed May 26, 2017
    Configuration menu
    Copy the full SHA
    d1e998b View commit details
    Browse the repository at this point in the history