Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation fixes #42

Closed
beckrob opened this issue Jan 31, 2019 · 1 comment
Closed

Installation fixes #42

beckrob opened this issue Jan 31, 2019 · 1 comment

Comments

@beckrob
Copy link

beckrob commented Jan 31, 2019

Dear Authors,

Thank you for sharing this package. In trying to install it, I came upon three small issues that could be fixed easily in the documentation/makefile and thus help others have a smoother installation process.

First, it would be helpful if it was specified that FFTW should also be installed with the --enable-shared configuration option. Otherwise there are problems when linking (message: relocation ... can not be used when making a shared object; recompile with -fPIC).

Second, it could also be specified that HEALPix should be installed with the shared C libraries, too (by default only a static library is linked).

Third, there were two typos in the Makefile generated by the configure script. Here are the lines:
libnmt_la_LDFLAGS = $(OPENP_CFLAGS) -lfftw3 -lfftw3_omp -lgsl -lgslcblas -lcfitsio -lsharp -lfftpack -lc_utils -lm
test_check_nmt_LDFLAGS = $(OPENP_CFLAGS) -L./ -lnmt -lfftw3 -lfftw3_omp -lgsl -lgslcblas -lcfitsio -lsharp -lfftpack -lc_utils -lm

OPENP_CFLAGS should actually read OPENMP_CFLAGS. Without -fopenmp the linking fails at the end.

I hope this helps.

Sincerely,
Robert Beck

@damonge
Copy link
Collaborator

damonge commented Jan 31, 2019

Hi @beckrob . Thanks a lot for bringing these up! I'm quite surprised that the OPENP stuff has been passing the travis tests all these time!

I've addressed these in PR #43 , which has been merged into master now.

@damonge damonge closed this as completed Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants