-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
latest libsharp #70
Comments
Kudos to @gfabbian for bringing this up |
The main change is that |
It's slightly more complicated than that as also the FFT library and linking changed. I got it running at NERSC with the lib sharp version distributed in Healpix 3.5 and with the version checked out from the repo. Any preference how to solve this? In order to keep the support for all library version then some preprocessing statements in the code to be specified when compiling should be enough. |
Hey @gfabbian . Did you have to modify NaMaster itself (including the configure scripts)? If so, a PR form a fork would be ideal (as would any instructions to reproduce what you had to do). |
Yes, slightly. I am working for a proper modification of the config file and then do the PR. I also need edto to port the c_libs from the old libsharp version as it is no longer distributed with the new version. I think the licence allows that. |
It's done and I've submitted a PR. If @xzackli or others want to check can also pull from my fork. Let me know if edits to the doc are needed or something is not clear or, worse, not working! |
I'm gonna close this for the time being, since the gitlab version seems to still be under development (or at least it's been changing significantly lately). I'll get back to this once things are stable. |
We should try and move to the latest version of libsharp, which is currently hosted in gitlab (https://gitlab.mpcdf.mpg.de/mtr/libsharp). I just found out about this now
The text was updated successfully, but these errors were encountered: