Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest libsharp #70

Closed
damonge opened this issue Oct 23, 2019 · 7 comments
Closed

latest libsharp #70

damonge opened this issue Oct 23, 2019 · 7 comments
Labels
enhancement New feature or request

Comments

@damonge
Copy link
Collaborator

damonge commented Oct 23, 2019

We should try and move to the latest version of libsharp, which is currently hosted in gitlab (https://gitlab.mpcdf.mpg.de/mtr/libsharp). I just found out about this now

@damonge damonge added the enhancement New feature or request label Oct 23, 2019
@damonge
Copy link
Collaborator Author

damonge commented Oct 23, 2019

Kudos to @gfabbian for bringing this up

@damonge damonge closed this as completed Oct 23, 2019
@damonge damonge reopened this Oct 23, 2019
@xzackli
Copy link
Collaborator

xzackli commented Oct 26, 2019

The main change is that ntrans is no longer a parameter for sharp_execute. You'll have to transform the 0 and 2 maps with two calls to sharp_execute, I think. I also had some trouble getting the sharp_Ylmgen_destroy function from configure.ac to be found.

@gfabbian
Copy link

It's slightly more complicated than that as also the FFT library and linking changed. I got it running at NERSC with the lib sharp version distributed in Healpix 3.5 and with the version checked out from the repo. Any preference how to solve this? In order to keep the support for all library version then some preprocessing statements in the code to be specified when compiling should be enough.

@damonge
Copy link
Collaborator Author

damonge commented Oct 29, 2019

Hey @gfabbian . Did you have to modify NaMaster itself (including the configure scripts)? If so, a PR form a fork would be ideal (as would any instructions to reproduce what you had to do).

@gfabbian
Copy link

Yes, slightly. I am working for a proper modification of the config file and then do the PR. I also need edto to port the c_libs from the old libsharp version as it is no longer distributed with the new version. I think the licence allows that.

@gfabbian
Copy link

It's done and I've submitted a PR. If @xzackli or others want to check can also pull from my fork. Let me know if edits to the doc are needed or something is not clear or, worse, not working!

@damonge
Copy link
Collaborator Author

damonge commented Dec 18, 2019

I'm gonna close this for the time being, since the gitlab version seems to still be under development (or at least it's been changing significantly lately). I'll get back to this once things are stable.

@damonge damonge closed this as completed Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants