Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

difference between demo_phasevocoder.m and the win32 executable pvdoneright.exe #11

Open
lszhou0126 opened this issue Oct 25, 2022 · 5 comments

Comments

@lszhou0126
Copy link

Hi,

When I run demo_phasevocoder.m and pvdoneright.exe of the same input signal, I got two outputs with big difference. For stretch of 2, the output of pvdoneright.exe sounds good, while some music noise in the output of demo_phasevocoder.m. May I known is there any diference between them. Thanks

@nholighaus
Copy link
Collaborator

nholighaus commented Oct 25, 2022 via email

@lszhou0126
Copy link
Author

I put the input and outputs at the attachment zif file. And the configure of 'flags' as follow, it says that the demo using the 'rtpghi' algorithm for phase propagation.
image
wav.zip

@nholighaus
Copy link
Collaborator

Thank you for providing details. There is definitely a noticeable difference in results. I can also reproduce your result obtained with phasecvocoder.m.

It is difficult to judge with the shifted (instead of stretched) output, but if I play the output from the executable at half speed and the twice stretched output of phasevocoder.m, my subjective impression is that the latter is closer in timbre to the input. The result from the executable has a roughness/mid-frequency noise that is not present, or at least much weaker, in the input. As a consequence, the shifted signal from the executable sounds 'richer', but I would argue that this is an artifact. I would actually prefer the phasevocoder.m output.

Nonetheless, we should figure out where the difference comes from. I will try digging out the source of the executable, but that will take some time.

@lszhou0126
Copy link
Author

Thank you for your replay, and I'm looking forward to it.

@susnak
Copy link
Contributor

susnak commented Jul 21, 2023

The C code is now available here
https://github.com/ltfat/pvdoneright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants