Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw warning if users try to write fhx objects with non-canon "rec_types" to FHX file. #149

Closed
brews opened this issue Aug 1, 2019 · 0 comments
Closed

Throw warning if users try to write fhx objects with non-canon "rec_types" to FHX file. #149

brews opened this issue Aug 1, 2019 · 0 comments
Assignees
@brews
Labels
enhancement New feature or request
Milestone
v0.5.0

Comments

@brews
Copy link
Member

brews commented Aug 1, 2019

We don't want to break the "FHX2 file convention" but users like to screw around with custom "rec_types" to fit their research needs. Write a warning into write_fhx() to let them know that these non-canon rec_types may trigger Ragnarök if they write it to an FHX file.
@brews brews added the enhancement New feature or request label Aug 1, 2019
@brews brews added this to the v0.5.0 milestone Aug 1, 2019
@brews brews self-assigned this Aug 1, 2019
@brews brews closed this as completed in ede3c94 Aug 1, 2019
brews added a commit that referenced this issue Aug 1, 2019
@brews
Merge pull request #152 from brews/master
e1655ce 
close #146, close #150, close #149, fix citations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brews brews

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.5.0
Development

No branches or pull requests
1 participant
@brews