Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "." in non-S3 method functions with "_" for consistent style #146

Closed
4 tasks
brews opened this issue Jul 30, 2019 · 0 comments
Closed
4 tasks

Replace "." in non-S3 method functions with "_" for consistent style #146

brews opened this issue Jul 30, 2019 · 0 comments
Assignees
@brews
Labels
enhancement New feature or request
Milestone
v0.5.0

Comments

@brews
Copy link
Member

brews commented Jul 30, 2019

Replace "." in non-S3 method functions with "_" for consistent style. For example is.fhx() should be is_fhx(). Maybe we can still use is.fhx() as an alias for is_fhx().

Here is a checklist of functions to check out and fix:

  • is.intervals
  • is.sea
  • is.fhx
  • as.fhx
@brews brews added the enhancement New feature or request label Jul 30, 2019
@brews brews added this to the v0.5.0 milestone Jul 30, 2019
@brews brews self-assigned this Jul 30, 2019
@brews brews closed this as completed in a01c15c Aug 1, 2019
brews added a commit that referenced this issue Aug 1, 2019
@brews
Merge pull request #152 from brews/master
e1655ce 
close #146, close #150, close #149, fix citations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brews brews

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.5.0
Development

No branches or pull requests
1 participant
@brews