Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

Large YML files taking very long to open & close #77

Closed
jutkko opened this issue Nov 29, 2016 · 10 comments
Closed

Large YML files taking very long to open & close #77

jutkko opened this issue Nov 29, 2016 · 10 comments

Comments

@jutkko
Copy link

jutkko commented Nov 29, 2016

For long bosh release manifests, vim takes 5-10+ seconds to open and quit. This issue was not present in 32f626785a2fbea88efc349511c05bd51e336f8c

@luan
Copy link
Owner

luan commented Nov 30, 2016

Do you have an example (redacted) manifest that reproduces the issue?

@totherme
Copy link
Contributor

totherme commented Dec 5, 2016

It seems like redacting our manifests causes the issue to go away... But so does commenting out the vim-bosh line in the ~/.vim/Plug.vim :S

@luan
Copy link
Owner

luan commented Dec 5, 2016

I'd still like to see an example manifest if that's possible @jutkko @totherme.

@totherme
Copy link
Contributor

totherme commented Dec 5, 2016

It turned out that the problem was running ~/.vim/update instead of cd ~/.vim ; update. The former causes slow bosh manifest parsing times, while the latter works fine.

We've updated the scripts that update all our dev boxes each morning accordingly, but the README still recommends the other.

@luan
Copy link
Owner

luan commented Dec 7, 2016

That doesn't make any sense o.O

The script does the same thing regardless of where it's ran from. And it should have no effect in how fast anything is. Can I get that file? I'm still interested in trying to make vim-bosh faster.

@totherme
Copy link
Contributor

totherme commented Dec 8, 2016

I'll get it to you in a side-channel, since redacting it seems to make the problem go away.

@totherme
Copy link
Contributor

Hopefully you now have the manifest I sent you by other means. Here's some more info about the problem:

The problem only occurs after running your update script from my home directory. So cd ; ~/.vim/update causes the problem, but cd ~/.vim ; ./update does not. I've also tried cd $ONE_OF_MY_PROJECT_PATHS ; ~/.vim/update, and vim works perfectly fine after that. So it feels like there's something in my home dir that interacts poorly with your update script.

Now is therefore probably a good time to mention our team's home dir setup. On our team, the home directory of each of our machines is a git repo, with a .gitignore file containing one line:

*

We use git add -f to check in various useful config files and scripts. Your scripts live in ~/.vim which is ignored. We do not attempt to submodule your scripts, or anything like that.

@totherme
Copy link
Contributor

I've just seen the problem again even though my ./update was run from inside the ~/.vim directory -- but I swear it made a difference before!

The manifest I sent you still triggers the problem, and I worked around it this time by commenting out the bosh plugin on line 291 of ~/.vim/Plug.vim

@totherme
Copy link
Contributor

Just installed nvim to see if it helped -- it doesn't :/

@luan
Copy link
Owner

luan commented Jan 12, 2017

Yeah, the bosh plugin is very beta, I didn't expect it to cause problems like this but I'm not surprised it did. I'll have to work on fixing that luan/vim-bosh#4. I'm closing the issue on this repo since it's not directly a problem with the vim config but a problem with the plugin.

@luan luan closed this as completed Jan 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants