♻ Simplify iterator and removeWhere logic
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lig
commented
Nov 27, 2020
|
@luanpotter what do you think? |
luanpotter
reviewed
Nov 29, 2020
luanpotter
reviewed
Nov 29, 2020
|
Nice cleanup! So should we merge this first and then the non-null thing? @lig |
|
@luanpotter I would like to get this in first and then rebase null safety on it. As far as I see around what others are doing in other projects it is better to keep the null safety code in a separate branch for now and release |
Co-authored-by: Luan Nico <luanpotter27@gmail.com>
|
@luanpotter great thanks! Give me some time to rebase #5 then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.