Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roblox Studio latest release has issues with nested generic types leaking #484

Closed
AmberGraceRblx opened this issue May 16, 2022 · 5 comments · Fixed by #491
Closed

Roblox Studio latest release has issues with nested generic types leaking #484

AmberGraceRblx opened this issue May 16, 2022 · 5 comments · Fixed by #491
Assignees
@asajeffrey
Labels
bug Something isn't working

Comments

@AmberGraceRblx
Copy link
Contributor

Devforum link: https://devforum.roblox.com/t/generic-types-have-leaks-issues-since-last-update-breaking-previously-valid-code/1794230
@AmberGraceRblx AmberGraceRblx added the bug Something isn't working label May 16, 2022
@AmberGraceRblx
Copy link
Contributor Author

AmberGraceRblx commented May 16, 2022 •
edited
Loading

Edit2: There seems to be unit tests coming very close to this issue, but passing just barely.

image

This unit test requires that the code has errors. It does in fact have a warning, but for the wrong reason. And types are still leaking.

@asajeffrey
Copy link
Collaborator

OK, I tracked this down to https://github.com/Roblox/luau/blob/ab4bb355a3f261d18ae8c0d09ce44a7af67ecaf9/Analysis/src/TypeInfer.cpp#L5395-L5397 Hopefully nothing is relying on this bug compatibility.

@asajeffrey
Copy link
Collaborator

@ambers-careware I'd like to check your examples in as unit tests. Are you OK with the examples being MIT licensed?

@AmberGraceRblx
Copy link
Contributor Author

@ambers-careware I'd like to check your examples in as unit tests. Are you OK with the examples being MIT licensed?

Yep, feel free to use!

@asajeffrey
Copy link
Collaborator

Thanks!

@zeux zeux mentioned this issue May 19, 2022
Merged
@zeux zeux closed this as completed in #491 May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asajeffrey asajeffrey

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sync to upstream/release/527 luau-lang/luau
2 participants
@asajeffrey @AmberGraceRblx