Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash on demo pipeline #128

Closed
luismavs opened this issue Jun 8, 2023 · 2 comments · Fixed by #134
Closed

crash on demo pipeline #128

luismavs opened this issue Jun 8, 2023 · 2 comments · Fixed by #134
Labels
bug Something isn't working priority: now

Comments

@luismavs
Copy link

luismavs commented Jun 8, 2023

Hi,
Great idea and nice project : )

Experimenting with version 0.3.1, I followed the tutorial to create a very basic pipeline (copying your script to

https://lucafaggianelli.github.io/plombery/create-a-pipeline/

I get a crash when clicking on the Run button.

INFO:     127.0.0.1:50624 - "GET /runs HTTP/1.1" 500 Internal Server Error
ERROR:    Exception in ASGI application

  File "pydantic/tools.py", line 38, in pydantic.tools.parse_obj_as
  File "pydantic/main.py", line 342, in pydantic.main.BaseModel.__init__
pydantic.error_wrappers.ValidationError: 1 validation error for ParsingModel[List[plombery.schemas.TaskRun]]
__root__ -> 0 -> duration
  ensure this value is greater than 0 (type=value_error.number.not_gt; limit_value=0)

I then have to delete the plombery.db file to reset it.

Interestingly if I install plombery on a python 3.10 env, this only happens after clicking the Run button some 6 times (each time after I press I have to refresh the page to be able to re press it).

I'm running on conda envs in a mac os.

@lucafaggianelli lucafaggianelli added bug Something isn't working priority: now labels Jun 9, 2023
@lucafaggianelli
Copy link
Owner

Hi!

Thank you :)

mmm interesting bug, I wasn't able to reproduce it myself, but I think I got it. The demo pipeline is very quick to execute, it takes less than a millisecond so the duration is rounded to 0, moreover in case a pipeline is cancelled the duration is 0. So I'm relaxing the validation for the duration to >= 0 rather than >0.

This should solve the issue

@lucafaggianelli
Copy link
Owner

ah for the dialog problem I opened the issue #133 thanks for that as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: now
Projects
None yet
2 participants