Merge pull request #18 from lucaorio/develop

Added support for Sketch 50
lucaorio · May 10, 2018 · 2078305 · 2078305
2 parents cccd81c + fcda201
commit 2078305
Show file tree

Hide file tree

Showing 6 changed files with 39 additions and 8 deletions.
diff --git a/Sketch Styles Generator.sketchplugin/Contents/Resources/icons/styles-generator.png b/Sketch Styles Generator.sketchplugin/Contents/Resources/icons/styles-generator.png
diff --git a/Sketch Styles Generator.sketchplugin/Contents/Sketch/generate.js b/Sketch Styles Generator.sketchplugin/Contents/Sketch/generate.js
@@ -129,14 +129,24 @@ var compare = function compare(name, styles) {
 
 // create new layer style
 var create = function create(name, style, styles, count) {
-  styles.addSharedStyleWithName_firstInstance(name, style);
+  if (styles.addSharedStyleWithName_firstInstance) {
+    styles.addSharedStyleWithName_firstInstance(name, style);
+  } else {
+    var s = MSSharedStyle.alloc().initWithName_firstInstance(name, style);
+    styles.addSharedObject(s);
+  }
   count.created++;
 };
 
 // update existing layer style, syncronize the instances
 var update = function update(style, pointer, styles, count) {
-  styles.updateValueOfSharedObject_byCopyingInstance(pointer, style);
-  styles.synchroniseInstancesOfSharedObject_withInstance(pointer, style);
+  if (styles.updateValueOfSharedObject_byCopyingInstance) {
+    styles.updateValueOfSharedObject_byCopyingInstance(pointer, style);
+    styles.synchroniseInstancesOfSharedObject_withInstance(pointer, style);
+  } else {
+    pointer.updateToMatch(style);
+    pointer.resetReferencingInstances();
+  }
   count.updated++;
 };
 

diff --git a/Sketch Styles Generator.sketchplugin/Contents/Sketch/manifest.json b/Sketch Styles Generator.sketchplugin/Contents/Sketch/manifest.json
@@ -21,7 +21,7 @@
       "generate"
     ]
   },
-  "version": "1.3.1",
+  "version": "1.3.2",
   "description": "Programmatically generate Shared Styles based on the layers name",
   "homepage": "https://github.com/lucaorio/sketch-styles-generator#readme",
   "disableCocoaScriptPreprocessor": true

diff --git a/appcast.xml b/appcast.xml
@@ -31,5 +31,16 @@
         </description>
         <enclosure url="https://github.com/lucaorio/sketch-styles-generator/releases/download/v1.3.1/sketch-styles-generator.zip" sparkle:version="1.3.1" />
       </item>
+      <item>
+        <title>Sketch Styles Generator 1.3.2</title>
+        <description>
+          <![CDATA[
+            <ul>
+              <li>Updates for Sketch 50</li>
+            </ul>
+          ]]>
+        </description>
+        <enclosure url="https://github.com/lucaorio/sketch-styles-generator/releases/download/v1.3.2/sketch-styles-generator.zip" sparkle:version="1.3.2" />
+      </item>
   </channel>
 </rss>
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "sketch-styles-generator",
-  "version": "1.3.1",
+  "version": "1.3.2",
   "description": "Programmatically generate Shared Styles based on the layers name",
   "author": "Luca Orio",
   "homepage": "https://github.com/lucaorio/sketch-styles-generator#readme",

diff --git a/src/generate.js b/src/generate.js
@@ -49,14 +49,24 @@ const compare = (name, styles) => Object.keys(styles).find(x => x == name);
 
 // create new layer style
 const create = (name, style, styles, count) => {
-  styles.addSharedStyleWithName_firstInstance(name, style);
+  if (styles.addSharedStyleWithName_firstInstance) {
+    styles.addSharedStyleWithName_firstInstance(name, style);
+  } else {
+    const s = MSSharedStyle.alloc().initWithName_firstInstance(name, style);
+    styles.addSharedObject(s);
+  }
   count.created++;
 };
 
 // update existing layer style, syncronize the instances
 const update = (style, pointer, styles, count) => {
-  styles.updateValueOfSharedObject_byCopyingInstance(pointer, style);
-  styles.synchroniseInstancesOfSharedObject_withInstance(pointer, style);
+  if (styles.updateValueOfSharedObject_byCopyingInstance) {
+    styles.updateValueOfSharedObject_byCopyingInstance(pointer, style);
+    styles.synchroniseInstancesOfSharedObject_withInstance(pointer, style);
+  } else {
+    pointer.updateToMatch(style);
+    pointer.resetReferencingInstances();
+  }
   count.updated++;
 };