New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3 support #1

Closed

Lucas-C opened this issue Jul 24, 2015 · 1 comment

Owner

Lucas-C commented Jul 24, 2015

Currently all hooks fail.
Fix suggestion:

non_printable_chars = ''.join(c for c in stuff if c not in string.printable)

But false CRLF & tabs positives are still detected:

CRLF end-lines remover.................................................................................................................................................................Failed
hookid: remove-crlf

CRLF end-lines have been successfully removed. Now aborting the commit.
You can check the changes made. Then simply "git add --update ." and re-commit

The text was updated successfully, but these errors were encountered:

Owner Author

Lucas-C commented Aug 3, 2015

Solved by commit 4d80144.

Lucas-C closed this as completed

Lucas-C mentioned this issue

Add support for Python 3 to is_textfile #4

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment