Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused StripGreasedVersions function #3214

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

marten-seemann
Copy link
Member

Such a function would defeat the purpose of greasing. Fortunately, we didn't actually use it anywhere.

Such a function would defeat the purpose of greasing. Fortunately, we didn't
actually use it anywhere.
@codecov
Copy link

codecov bot commented Jun 27, 2021

Codecov Report

Merging #3214 (9520f24) into master (e9d12b7) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3214   +/-   ##
=======================================
  Coverage   85.40%   85.41%           
=======================================
  Files         134      134           
  Lines        9825     9821    -4     
=======================================
- Hits         8391     8388    -3     
+ Misses       1060     1059    -1     
  Partials      374      374           
Impacted Files Coverage Δ
internal/protocol/version.go 95.00% <ø> (-0.45%) ⬇️
internal/utils/rand.go 75.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d12b7...9520f24. Read the comment docs.

@marten-seemann marten-seemann merged commit ae4937a into master Jul 6, 2021
@marten-seemann marten-seemann deleted the remove-strip-greased-versions branch July 6, 2021 16:51
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants