Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement search with Algolia #281

Closed
lucavallin opened this issue Oct 25, 2023 · 5 comments
Closed

Implement search with Algolia #281

lucavallin opened this issue Oct 25, 2023 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@lucavallin
Copy link
Owner

Searching is currently done by looping through the repository array and finding the one matching criteria. This is computationally very expensive and something like Algolia might help us.

@lucavallin lucavallin added enhancement New feature or request help wanted Extra attention is needed labels Oct 25, 2023
@lukebrichey
Copy link

Interested in taking this on over the weekend. At a high level, what would be involved to implement this? Also, are there any other solutions you are considering other than Algolia?

@lucavallin
Copy link
Owner Author

Hey @lukebrichey! Thanks for the interest. I am not sure, Algolia has a service that takes your json and makes it more searchable, or so I heard. Something I'd need to look into as well. I think kbar is another such tool. The golden solution would be to have a database instead of a json file.

@lukebrichey
Copy link

Gotcha, haven't heard of Algolia before but I would be down to try it out.

@lukebrichey
Copy link

Hey Luca, was about to start working on search. Is the database more of a priority? If so, would be happy to take that issue on instead and work on search features later.

@lucavallin
Copy link
Owner Author

@lukebrichey No specific priority. Database is cool but it will take a lot more work. Feel free to work on your favourite issue ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants