Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all Interface methods to be package methods taking context #53

Closed
riannucci opened this issue Jul 26, 2016 · 1 comment
Closed

Comments

@riannucci
Copy link
Member

So instead of:

ds := datastore.Get(c)
err := ds.Get(model)
err := ds.Get(model)

it would be

err := ds.Get(c, model)
err := ds.Get(c, model)

This would allow per-rpc timeouts to be a lot less awkward (since you're passing the context in).

This would be done to all services (adding RawInterface if necessary for services that don't split them apart).

@riannucci
Copy link
Member Author

suggested by @vadimsht

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant