component update clears innerHTML?

[fritx]

<Editor ref="edit" id="editor" className="edit"
              style={{
                fontFamily: fields.fontFamily.value,
                fontSize: fields.fontSize.value,
                fontWeight: fields.fontBold.value ? 'bold' : 'normal',
                color: fields.fontColor.value,
              }}
              onKeyDown={(e)=>this.onKeyDown(e)}
              onInput={(e)=>this.onInput(e)}
              dangerouslySetInnerHTML={{__html: currConver.editor}} />

It seems the innerHTML clears when one of the css style updates.
When I switch back to react, it works.
Is it a bug of react-lite?

[Lucifier129]

I wonder the type of currConver.editor, it's string or not?

since:

let oldHtml = oldValue && oldValue.__html
let html = value && value.__html
if (!isStr(html)) {
  elem.innerHTML = ''
} else if (html !== oldHtml) {
  elem.innerHTML = html
}

[Lucifier129]

if currConver.editor is equal to undefined, innerHTML will also be clears.

Had better got a demo for debugging:)

[fritx]

Yes, you're right. It is undefined 😢
But this is different with React. Is it better to make them consistent? ;)

[Lucifier129]

@fritx That's ok, I will check the behavior about inneHTML in this case with react, and make them consistent.

[fritx]

Thanks! At this time, I prefer consistancy. Thank you!
But maybe in the future, react-lite's simplicity and lightweight wins!

[Lucifier129]

I think the version v0.0.13 of react-lite made consistancy with below change:

let oldHtml = oldValue && oldValue.__html
let html = value && value.__html
if (html != null && html !== oldHtml) {
  elem.innerHTML = html
}

It won't be patched if html is equal to null or undefined such like regular react does.

try the lastest version to confirm this problem was resolved:)

BTW, I think regular react will provide lightweight version in the feature, or something like rollup \ tree shaking, make react-lite not necessary

haha ~ just wait and see what will happen.

[fritx]

@Lucifier129 haha~ ok, wait a sec

[fritx]

Ok alright!

• It won't be patched if html is equal to null or undefined
• It will be patched if html is equal to empty string

[Lucifier129]

That's good:)

[dhenson02]

issue should be closed 👍