Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players with luckperms.autoop can use all luckperms commands even though commands-allow-op is false #3899

Open
MCMDEV opened this issue May 27, 2024 · 1 comment
Labels
type: issue The issue identifies a bug/problem with the software.

Comments

@MCMDEV
Copy link

MCMDEV commented May 27, 2024

Description

If the commands-allow-op config value in LuckPerms is set to false AND the config value auto-op is true AND a player has the permission luckperms.autoop, they can use all LuckPerms commands.

Reproduction Steps

Change the following values according to this in the config.yml

apply-bukkit-default-permissions: false
apply-bukkit-child-permissions: false
enable-ops: false
auto-op: true
commands-allow-op: false

Expected Behaviour

A player with just the luckperms.autoop permission should not be able to use any LuckPerms commands

Server Details

git-Paper-392 (MC: 1.20.4)

LuckPerms Version

v5.4.130

Logs and Configs

No response

Extra Details

This might be expected behavior, but if so I believe it really shouldn't be.

@MCMDEV MCMDEV added the type: issue The issue identifies a bug/problem with the software. label May 27, 2024
@MCMDEV
Copy link
Author

MCMDEV commented May 28, 2024

I've taken a look at the source code and figured that the reason this doesn't work is actually because if apply-bukkit-default-permissions is false, the commands-allow-op option is ignored as it is implemented using default permissions.

Some possible solutions are:

  • Implement an edge case into the OP-Processor that denies LuckPerms permission if commands-allow-op is false
  • Implement an edge case into the LuckPermsPermissible class
  • Update the config and tell users that default permissions are required for commands-allow-op as false to work.

I'm happy to create a PR for either, I'd just like a maintainer to make a decision so I don't waste the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: issue The issue identifies a bug/problem with the software.
Projects
None yet
Development

No branches or pull requests

1 participant