Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for older Xcode 8.2.1 #7

Closed
aonez opened this issue Aug 17, 2017 · 1 comment
Closed

Support for older Xcode 8.2.1 #7

aonez opened this issue Aug 17, 2017 · 1 comment

Comments

@aonez
Copy link

aonez commented Aug 17, 2017

Continuing from #6, also had to change some code in order to compile the framework, due the fact that I'm using Xcode 8.2.1 (8C1002), old Mac with 10.11 El Capitan, old Swift libraries.

Don't know if you want to make the framework compatible with legacy versions of Swift. No changes needed on current Xcode 8.3.3 👍

Here the changes I've made. Know that just made them quick so the compiler let me try the framework.

@nfgrilo
Copy link
Contributor

nfgrilo commented Oct 13, 2017

Thank you!

However, as I have just converted ThemeKit to Swift 4 (1.1.0), Xcode 9 is now a requirement, so I will close this ticket as is. Your changes can still be very useful for anyone using ThemeKit 1.0.0 (which uses Swift 3.2) + Xcode 8 👍

Again, thanks!

@nfgrilo nfgrilo closed this as completed Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants