Test code on 🐍 3.12
#1080
Merged
Test code on 🐍 3.12
#1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abandoned-prototype @b-meson, presuming this gets merged could y'all mark the |
michplunkett
commented
Dec 29, 2023
| @@ -1,6 +1,6 @@ | |||
| ARG MAKE_PYTHON_VERSION | |||
| ARG DOCKER_BUILD_ENV | |||
| FROM python:${MAKE_PYTHON_VERSION:-3.11}-buster | |||
| FROM python:${MAKE_PYTHON_VERSION:-3.11}-bullseye | |||
There was a problem hiding this comment.
We use slim-bullseye for our production build, but that didn't seem to work for the test build. The Seattle instance uses bullseye so we should be golden.
sea-kelp
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
#1031
Description of Changes
Update 🐍 version matrix to include
3.12. At some point I'd like to move the application to3.12, but I think now isn't the time.Tests and linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.