Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test code on 🐍 3.12 #1080

Merged
merged 5 commits into from
Dec 29, 2023
Merged

Test code on 🐍 3.12 #1080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ceba30f
Update test_prs.yml
michplunkett Dec 28, 2023
41104ff
Update test_prs.yml
michplunkett Dec 28, 2023
3d47d13
Update test_prs.yml
michplunkett Dec 29, 2023
744f13c
Update Dockerfile
michplunkett Dec 29, 2023
2596155
Update Dockerfile
michplunkett Dec 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test_prs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
FLASK_APP: OpenOversight.app
strategy:
matrix:
python-version: ["3.11"]
python-version: ["3.11", "3.12"]
# Steps represent a sequence of tasks that will be executed as part of the job
steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/web/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ARG MAKE_PYTHON_VERSION
ARG DOCKER_BUILD_ENV
FROM python:${MAKE_PYTHON_VERSION:-3.11}-buster
FROM python:${MAKE_PYTHON_VERSION:-3.11}-bullseye
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use slim-bullseye for our production build, but that didn't seem to work for the test build. The Seattle instance uses bullseye so we should be golden.


WORKDIR /usr/src/app

Expand Down