Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output error: Exceeded step memory limit at some point #277

Closed
sumeshpt opened this issue Jul 31, 2023 · 4 comments
Closed

Output error: Exceeded step memory limit at some point #277

sumeshpt opened this issue Jul 31, 2023 · 4 comments
Assignees
Labels
shortcoming This doesn't seem right

Comments

@sumeshpt
Copy link
Contributor

The attached input produces this error at the end of the run, though it seems to produce the desired output. Not sure whether it has consequences.

input.txt

@kevinstratford
Copy link
Collaborator

I suspect this a failure to allocate memory at the
point where the configuration output is written at
the end of the run.

It's a bit unfortunate that you have to wait that
long to find out. We should investigate a way to
bring the problem forward to the start of the run.

@kevinstratford kevinstratford self-assigned this Jul 25, 2024
@kevinstratford kevinstratford added the shortcoming This doesn't seem right label Jul 25, 2024
@kevinstratford kevinstratford added this to the Release 0.23.0 milestone Jul 25, 2024
@kevinstratford
Copy link
Collaborator

I will find a way to prevent this issue (or at least run out of memory at the start of the run).

@kevinstratford
Copy link
Collaborator

This is a problem with out-of-memory (OOM) and as such cannot be fixed or handled. The only thing we can really do is to try to fail early in the proceedings.

So I've added some code to do this by running the i/o aggregation step once at initialisation. This is not completely foolproof, but reasonable examples suggest it does bring the failure forward.

There is a risk that this extra memory requirement at the start induces failure when no output is actually wanted. However, I think we will accept that, lesser, evil.

This is #318

@kevinstratford
Copy link
Collaborator

That should be ok (famous last words)....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shortcoming This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants