Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support .NET Framework versions providing RuntimeInformation #261

Merged
merged 3 commits into from
Oct 17, 2020
Merged

Support .NET Framework versions providing RuntimeInformation #261

merged 3 commits into from
Oct 17, 2020

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Oct 7, 2020 •
edited by luigiberrettini
Loading

@snakefoot snakefoot force-pushed the ReferenceAssemblies branch 4 times, most recently from 8a03ada to 5cb0ea5 Compare October 7, 2020 20:22
@cwigley
Copy link

cwigley commented Oct 7, 2020

Guessing that if your build changes go through they will solve for the mono dependency problem my builds are running up against.

@snakefoot
Copy link
Contributor Author

@cwigley That was the plan. And can see net452 + net461 projects now compiles without help from FrameworkPathOverride.

Now trying to add net471 as targetframework.

@snakefoot
Copy link
Contributor Author

Yes everything is green nuget-package with net471 on both AppVeyor and Travis

@snakefoot snakefoot changed the title Replaced travis FrameworkPathOverride with Microsoft.NETFramework.ReferenceAssemblies Replaced travis FrameworkPathOverride with ReferenceAssemblies and net471 Oct 8, 2020
@luigiberrettini luigiberrettini added this to the 6.0.2 milestone Oct 17, 2020
@luigiberrettini luigiberrettini changed the title Replaced travis FrameworkPathOverride with ReferenceAssemblies and net471 Support .NET Framework versions providing RuntimeInformation Oct 17, 2020
@luigiberrettini luigiberrettini mentioned this pull request Oct 17, 2020
Closed
@luigiberrettini
Copy link
Owner

Supersedes #260

@luigiberrettini luigiberrettini merged commit 119a921 into luigiberrettini:master Oct 17, 2020
@snakefoot
Copy link
Contributor Author

Maybe ready for release of ver. 6.0.2 ?

@luigiberrettini
Copy link
Owner

Version 6.0.2 has been released 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
6.0.2
Development

Successfully merging this pull request may close these issues.

RuntimeInformation package used also when not needed
3 participants
@snakefoot @cwigley @luigiberrettini