Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux 3.16 build fix #21

Closed
GoogleCodeExporter opened this issue Mar 30, 2015 · 1 comment
Closed

Linux 3.16 build fix #21

GoogleCodeExporter opened this issue Mar 30, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

hi, the macro SET_ETHTOOL_OPS was eliminated. Obvious patch follows:

diff --git a/sys/dev/netmap/netmap_kern.h b/sys/dev/netmap/netmap_kern.h
index fd84e70..0c140cd 100644
--- a/sys/dev/netmap/netmap_kern.h
+++ b/sys/dev/netmap/netmap_kern.h
@@ -789,7 +789,7 @@ nm_set_native_flags(struct netmap_adapter *na)
        na->if_transmit = (void *)ifp->netdev_ops;
        ifp->netdev_ops = &((struct netmap_hw_adapter *)na)->nm_ndo;
        ((struct netmap_hw_adapter *)na)->save_ethtool = ifp->ethtool_ops;
-       SET_ETHTOOL_OPS(ifp, &((struct netmap_hw_adapter*)na)->nm_eto);
+       ifp->ethtool_ops = &((struct netmap_hw_adapter*)na)->nm_eto;
 #endif
 }

@@ -803,7 +803,7 @@ nm_clear_native_flags(struct netmap_adapter *na)
        ifp->if_transmit = na->if_transmit;
 #else
        ifp->netdev_ops = (void *)na->if_transmit;
-       SET_ETHTOOL_OPS(ifp, ((struct netmap_hw_adapter*)na)->save_ethtool);
+       ifp->ethtool_ops = ((struct netmap_hw_adapter*)na)->save_ethtool;
 #endif
        na->na_flags &= ~(NAF_NATIVE_ON | NAF_NETMAP_ON);
 #ifdef IFCAP_NETMAP /* or FreeBSD ? */

Original issue reported on code.google.com by schuma...@googlemail.com on 28 Sep 2014 at 1:35

@GoogleCodeExporter
Copy link
Author

Thank for the report and the patch. Note, however, that this is a duplicate of 
issue 18. The same considerations apply: the issue should be already fixed in 
the 'next' branch. Does that work for you?

Original comment by giuseppe.lettieri73 on 28 Sep 2014 at 1:55

  • Changed state: Duplicate
  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant