Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninitialized variable causing test failure #920

Closed
jcaplan opened this issue May 14, 2023 · 0 comments
Closed

Uninitialized variable causing test failure #920

jcaplan opened this issue May 14, 2023 · 0 comments

Comments

@jcaplan
Copy link

jcaplan commented May 14, 2023

netmap/utils/fd_server.c

Lines 123 to 125 in b58a473

if (marshal(res, entry) < 0)
return -1;
return entry->nmd->fd;

Similar to the end of the function since we’re returning a successful result here then res->result=0 should be set. Or res should be initialized to 0 in handle_request. Otherwise if there happens to be non-zero data there then the test fails for no reason because functional gets a non-zero return code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant