Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time resolution on rx sync #930

Open
vvsvvsvvs opened this issue Jul 5, 2023 · 1 comment
Open

Time resolution on rx sync #930

vvsvvsvvs opened this issue Jul 5, 2023 · 1 comment

Comments

@vvsvvsvvs
Copy link

Time resolution of microtime() is not enough for bursts of 1. There is a need for ktime_get_ts64().
How to reproduce:
run the bridge on the same interface with burst equal to 1 (network->stack->userland mode) and take timestamp of the ring (ring->ts),
ping the netmap host from another computer like
ping -s1000 -q -i 0.00001 1.2.3.4
You will get timestamp difference of 0 for up to 100 packets on average computer with 1Gbit iface.

Point: rings_move(..) in bridge.c.

@kierank
Copy link
Contributor

kierank commented Aug 29, 2023

IMO you should be using hardware timestamps for this level of precision.

I sent a PR for this: https://github.com/luigirizzo/netmap/pull/877/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants