[TLS] closes #1114 - add tlsSni option #1137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
This PR introduces a new boolean option
tlsSnithat will basically, when enabled, copy the Redis hostname totls.servernamebefore the connection initialization,allowing each node of a Redis Cluster to possess its own SNI.
This PR has been opened following the issue #1114
It is also related to #948
Thank you for your time!
PS: For clusers I had to copy the
options.hostvalue tooptions.hostOriginalbefore it gets processed by thednsLookupfunction, so that the original hostname could get passed to thetls.servernameoption instead of its IP.