-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keeps skipping iframe #98
Comments
Looking through your sources, you imagine that a video from youtube will have an 'embed' element which is wrong, these days all youtube videos are enclosed in an iframe, i found a way to solve this, maybe i might do a PR, It's just a single line i edited anyway |
Where are you expecting to see the iframe? I don't have context on why the iframes are removed, but I don't believe that the extension searches within iframes for potential content. Is this just so that they are within jsdom when the extraction completes? I'm not following the use case for this. |
@haroldtreen i wanted to extract youtube videos, but most are iframes. You remove iframes, some have youtube videos. in #99 i removed the line that cleans out iframes, will play with it later and valid if an iframe has a video. closing this now. |
Is there a way to pull iframes aswell? for example an iframe from youtube
The text was updated successfully, but these errors were encountered: