Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeps skipping iframe #98

Closed
patrickmuhi opened this issue Oct 16, 2017 · 4 comments
Closed

Keeps skipping iframe #98

patrickmuhi opened this issue Oct 16, 2017 · 4 comments

Comments

@patrickmuhi
Copy link

Is there a way to pull iframes aswell? for example an iframe from youtube

@patrickmuhi
Copy link
Author

Looking through your sources, you imagine that a video from youtube will have an 'embed' element which is wrong, these days all youtube videos are enclosed in an iframe,

i found a way to solve this, maybe i might do a PR,

It's just a single line i edited anyway

@patrickmuhi
Copy link
Author

#99

@haroldtreen
Copy link
Collaborator

Where are you expecting to see the iframe? I don't have context on why the iframes are removed, but I don't believe that the extension searches within iframes for potential content.

Is this just so that they are within jsdom when the extraction completes? I'm not following the use case for this.

@patrickmuhi
Copy link
Author

patrickmuhi commented Oct 21, 2017

@haroldtreen i wanted to extract youtube videos, but most are iframes. You remove iframes, some have youtube videos. in #99 i removed the line that cleans out iframes, will play with it later and valid if an iframe has a video. closing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants