Increase deploy timeouts and make them configurable #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s/deployments.go
Outdated
| } | ||
|
|
||
| var deploymentConfig DeploymentConfig | ||
|
|
||
| func init() { | ||
| err := envconfig.Process("teresadeploy", &deploymentConfig) | ||
| err := envconfig.Process("teresa_deploy", &deploymentConfig) |
There was a problem hiding this comment.
Why?
Is it because the upgrade of envconfig dependency ?
There was a problem hiding this comment.
No, I prefer this style for env vars: TERESA_* .
There was a problem hiding this comment.
Hum 🤔 but, this change will broke the env TERESADEPLOY_REVISION_HISTORY_LIMIT and is out of pattern of others env configs (like TERESAFILESTORAGE or TERESADB).
What do you think about?
There was a problem hiding this comment.
I would changed it right now as it is undocumented, but to be on the safer side we can change the env vars style for 0.3.0 and document the change. Agree?
There was a problem hiding this comment.
It's "documented" on README...
But 
drgarcia1986
approved these changes
Mar 30, 2017
Also upgrade to the latest envconfig.
aguerra
force-pushed
the
ag-increase-deploy-timeouts
branch
from
f381090
to
bbfc86e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also upgrade to the latest envconfig.
This change is