Finish grpc create app #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgarcia1986
reviewed
Jun 8, 2017
cmd/client/cmd/app.go
Outdated
| if team == "" { | ||
| fmt.Fprintln(os.Stderr, "You must provide the name of the team") | ||
| return | ||
| } |
There was a problem hiding this comment.
what about simplify this validation, like this:
team, err := cmd.Flags().GetString("team")
if err != nil || team == "" {
fmt.Fprintln(os.Stderr, "You must provide a valid name of the team")
return
}?
(or just ignore error and only check for blank team name)
There was a problem hiding this comment.
Your snippet is better.
cmd/client/cmd/app.go
Outdated
| } | ||
|
|
||
| scaleMin, _ := cmd.Flags().GetInt32("scale-min") | ||
| if err != nil { |
There was a problem hiding this comment.
- scaleMin, _ := cmd.Flags().GetInt32("scale-min")
+ scaleMin, err := cmd.Flags().GetInt32("scale-min")| Max: int64(666), | ||
| Min: int64(1), | ||
| CpuTargetUtilization: 42, | ||
| Max: 666, |
| ObjectMeta: k8sv1.ObjectMeta{ | ||
| Name: a.Name, | ||
| Labels: map[string]string{ | ||
| "teresa.io/team": a.Team, |
There was a problem hiding this comment.
Maybe I found a bug on #205 .
I was getting app team for teresa.io/app annotation 😕 .
There was a problem hiding this comment.
We talked and settled for using the label.
aguerra
force-pushed
the
ag-finish-create-app
branch
from
8f7402d
to
7c38bb6
Compare
26 tasks
aguerra
force-pushed
the
ag-finish-create-app
branch
from
7c38bb6
to
6ccee3f
Compare
drgarcia1986
approved these changes
Jun 9, 2017
pkg/server/app/app.go
Outdated
| CreateNamespace(*App, string) error | ||
| CreateQuota(*App) error | ||
| CreateSecret(string, string, map[string][]byte) error | ||
| CreateAutoScale(*App) error |
There was a problem hiding this comment.
💅 maybe a simple name for these args helps to understand they proposal 💅
pkg/server/app/app_test.go
Outdated
|
|
||
| if err := ops.Create(user, app); err == nil { | ||
| t.Errorf("expected error, got nil") | ||
| } |
There was a problem hiding this comment.
- if err := ops.Create(user, app); err == nil {
+ if ops.Create(user, app) == nil {
pkg/server/app/app_test.go
Outdated
| } | ||
| ops.(*AppOperations).kops = &errK8sOperations{QuotaErr: errors.New("Quota Error")} | ||
|
|
||
| if err := ops.Create(user, app); err == nil { |
There was a problem hiding this comment.
- if err := ops.Create(user, app); err == nil {
+ if ops.Create(user, app) == nil {
pkg/server/app/app_test.go
Outdated
| } | ||
| ops.(*AppOperations).kops = &errK8sOperations{AutoScaleErr: errors.New("AutoScale Error")} | ||
|
|
||
| if err := ops.Create(user, app); err == nil { |
There was a problem hiding this comment.
- if err := ops.Create(user, app); err == nil {
+ if ops.Create(user, app) == nil {
aguerra
force-pushed
the
ag-finish-create-app
branch
from
6ccee3f
to
a84c712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now I'm postponing error translation and setting the defaults on the server as this PR is already too big.
Related #203.
This change is