gRPC - App logs #205
Merged
gRPC - App logs #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with some relevant methods on K8sAppOperations
using oficial k8s client-go
26 tasks
aguerra
approved these changes
Jun 6, 2017
pkg/server/app/fake.go
Outdated
| } | ||
| if follow { | ||
| rand.Seed(42) // The Anwser | ||
| for i := 0; i <= rand.Intn(5); i++ { |
pkg/server/app/app.go
Outdated
| a := new(App) | ||
| if err := json.Unmarshal([]byte(annotation), a); err != nil { | ||
| return "", nil | ||
| } |
There was a problem hiding this comment.
I guess return "", err, right?
| "Comment": "v2.0.0", | ||
| "Rev": "e121606b0d09b2e1c467183ee46217fa85a6b672" | ||
| }, | ||
| { | ||
| "ImportPath": "k8s.io/kubernetes/pkg/api", | ||
| "Comment": "v1.4.0-alpha.2-550-gda53a24", |
There was a problem hiding this comment.
Not sure if these k8s.io/apimachinery shoud be here.
There was a problem hiding this comment.
I have tried to remove from Godeps.json and run godeps save ./..., but it's back again 😞
|
@aguerra I don't understand, are you suggest to remove arg |
|
As we talked in person this way is more granular so ok4me. |
now we log all pods with any status
Merged
drgarcia1986
commented
Jun 8, 2017
pkg/server/app/app.go
Outdated
| found = true | ||
| break | ||
| } | ||
| } | ||
| return found | ||
| } | ||
|
|
||
| func (ops *AppOperations) getAppTeam(appName string) (string, error) { | ||
| annotation, err := ops.kops.NamespaceAnnotation(appName, TeresaAnnotation) |
There was a problem hiding this comment.
Change to Label instead of Annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client-go(related #203 )
This change is