Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested numeric lists get flattened #23

Closed
jdickey opened this issue Oct 4, 2018 · 2 comments
Closed

Nested numeric lists get flattened #23

jdickey opened this issue Oct 4, 2018 · 2 comments
Labels
wontfix This will not be worked on

Comments

@jdickey
Copy link

jdickey commented Oct 4, 2018

Whether in the right-pane preview or exporting to either PDF or HTML, Twig can't tell that indenting some list items relative to others has significance.

Here's a selection of Markdown content that will demonstrate the problem:

First, we'll build out the basic, as-generated Hanami app in a Docker image. Initially starting from a Debian base, we'll build an image that

1. installs the Debian packages we've been using for our Ruby-development images, including the requirements (Qt5's `qmake`, `xvfb`, etc) for an image hosting `capybara-webkit` and/or `selenium`;
2. installs the current versions of Gems for
  1. Hanami 1.2; and
  2. Our evolving-standard suite of development tools, including
    1. `awesome_print`,
    2. `flay`,
    3. `flog`,
    4. `reek`,
    5. `rubocop`,
    6. `pry-byebug`,
    7. `simplecov`,
    8. various MiniTest add-ons.

(GitHub's Markdown renderer sees that's a numbered list with three levels of indentation.

How Twig renders that content can be seen here:

capturfiles

Obviously not what the markup specifies.

(Possibly related to #18.)

@lukakerr
Copy link
Owner

lukakerr commented Oct 6, 2018

It seems that GitHub uses a minimum of 3 (or 2?) spaces for nested indentation, whereas Twig (and cmark) use 4 spaces or a tab. In the screenshot below, using 4 spaces (or a tab) works fine. I don't intend to deviate from the cmark spec too much, so I'll close this as wontfix.

screen shot 2018-10-06 at 12 41 06 pm

@lukakerr lukakerr closed this as completed Oct 6, 2018
@jdickey
Copy link
Author

jdickey commented Oct 7, 2018

Understood and agreed. I've known that GitHub uses (and every other tool I've tried allows) 2 spaces for quite some time; it never dawned on me that the spec actually required 4. That's just inexcusable laziness on my part, as the spec going back four whole years to present does in fact specify 4 spaces as equivalent to a tab stop.

Thank you. TIL, and I've been living in Markdown daily for years now.

@lukakerr lukakerr added the wontfix This will not be worked on label Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants