Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Body needs to have 100% height to address issue with dark mode #4

Closed
finestgecko opened this issue Jun 22, 2020 · 3 comments
Closed

Comments

@finestgecko
Copy link

finestgecko commented Jun 22, 2020

I just wanted to give a heads-up about a minor issue with dark mode. On pages with less content, the bottom of the page is white.

I suggest to add height: 100% to the body.

@LukasJoswiak
Copy link
Owner

Hi, thanks for the heads up! Can you provide details about what environment you saw this issue in (OS, browser, browser version)? I'm unable to reproduce this.

@LukasJoswiak
Copy link
Owner

I don't have the right device to reproduce this issue. Please open a PR with the fix and I'll be happy to merge it in. It also looks like you may want to use min-height: 100% instead, based on https://stackoverflow.com/a/6654996/986991.

@finestgecko
Copy link
Author

finestgecko commented Jul 23, 2020

I'm going to close this issue, since I noticed the problem also sporadically occurs on other websites. I'm inclined to believe that it's not related to Etch.

Feel free to delete. Apologies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants